hodasemi/cgmath
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Remove duplicate code in the deprecated Matrix3::look_at function

Browse source
This commit is contained in:
Aaron Loucks 2020-06-26 23:51:39 -04:00 committed by Dzmitry Malyshau
parent c0a66d2a34
commit 3bd348127c
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/matrix.rs
View file

@ -191,11 +191,7 @@ impl<S: BaseFloat> Matrix3<S> {
/// `dir`, using `up` for orientation. /// `dir`, using `up` for orientation.
#[deprecated = "Use Matrix3::look_to_lh"] #[deprecated = "Use Matrix3::look_to_lh"]
pub fn look_at(dir: Vector3<S>, up: Vector3<S>) -> Matrix3<S> { pub fn look_at(dir: Vector3<S>, up: Vector3<S>) -> Matrix3<S> {
let dir = dir.normalize(); Matrix3::look_to_lh(dir, up)
let side = up.cross(dir).normalize();
let up = dir.cross(side).normalize();
Matrix3::from_cols(side, up, dir).transpose()
} }
/// Create a rotation matrix that will cause a vector to point at /// Create a rotation matrix that will cause a vector to point at