hodasemi/cgmath
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Add a default implementation for EuclideanVector::angle

Browse source
This commit is contained in:
Brendan Zabarauskas 2016-04-04 20:20:31 +10:00
parent 3b55ad5f70
commit 40a3ad3185
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/vector.rs
View file

@ -560,8 +560,10 @@ pub trait EuclideanVector: Vector + Sized where
Float::sqrt(self.magnitude2()) Float::sqrt(self.magnitude2())
} }
/// The angle between the vector and `other`, in radians. /// Returns the angle between two vectors in radians.
fn angle(self, other: Self) -> Rad<Self::Scalar>; fn angle(self, other: Self) -> Rad<Self::Scalar> {
Rad::acos(Self::dot(self, other) / (self.magnitude() * other.magnitude()))
}
/// Returns a vector with the same direction, but with a magnitude of `1`. /// Returns a vector with the same direction, but with a magnitude of `1`.
#[inline] #[inline]
@ -623,11 +625,6 @@ impl<S: BaseFloat> EuclideanVector for Vector4<S> {
fn dot(self, other: Vector4<S>) -> S { fn dot(self, other: Vector4<S>) -> S {
Vector4::mul_element_wise(self, other).sum() Vector4::mul_element_wise(self, other).sum()
} }
#[inline]
fn angle(self, other: Vector4<S>) -> Rad<S> {
Rad::acos(Self::dot(self, other) / (self.magnitude() * other.magnitude()))
}
} }
impl<S: fmt::Debug> fmt::Debug for Vector2<S> { impl<S: fmt::Debug> fmt::Debug for Vector2<S> {