hodasemi/cgmath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Removes #[repr(packed)] from all structs where it was specified.

Browse source 
This is intended as a partial fix for #375. It doesn't also remove #[repr(C)],
since it's a bit unclear whether that's necessary.
This commit is contained in:
Mark Hintz 2016-08-25 15:41:39 +02:00
parent 5b92765647
commit f475822d9b
6 changed files with 28 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/angle.rs
View file

@ -30,8 +30,8 @@ use num::BaseFloat;
/// An angle, in radians. /// An angle, in radians.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(Copy, Clone, PartialEq, PartialOrd)] #[derive(Copy, Clone, PartialEq, PartialOrd)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]
@ -39,8 +39,8 @@ pub struct Rad<S>(pub S);
/// An angle, in degrees. /// An angle, in degrees.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(Copy, Clone, PartialEq, PartialOrd)] #[derive(Copy, Clone, PartialEq, PartialOrd)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]

4
src/euler.rs
View file

@ -25,7 +25,7 @@ use num::BaseFloat;
/// A set of [Euler angles] representing a rotation in three-dimensional space. /// A set of [Euler angles] representing a rotation in three-dimensional space.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
/// ///
/// The axis rotation sequence is XYZ. That is, the rotation is first around /// The axis rotation sequence is XYZ. That is, the rotation is first around
/// the X axis, then the Y axis, and lastly the Z axis (using intrinsic /// the X axis, then the Y axis, and lastly the Z axis (using intrinsic
@ -72,7 +72,7 @@ use num::BaseFloat;
/// [Euler angles]: https://en.wikipedia.org/wiki/Euler_angles /// [Euler angles]: https://en.wikipedia.org/wiki/Euler_angles
/// [gimbal lock]: https://en.wikipedia.org/wiki/Gimbal_lock#Gimbal_lock_in_applied_mathematics /// [gimbal lock]: https://en.wikipedia.org/wiki/Gimbal_lock#Gimbal_lock_in_applied_mathematics
/// [convert]: #defining-rotations-using-euler-angles /// [convert]: #defining-rotations-using-euler-angles
#[repr(C, packed)] #[repr(C)]
#[derive(Copy, Clone, Debug)] #[derive(Copy, Clone, Debug)]
#[derive(PartialEq, Eq)] #[derive(PartialEq, Eq)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]

12
src/matrix.rs
View file

@ -33,8 +33,8 @@ use vector::{Vector2, Vector3, Vector4};
/// A 2 x 2, column major matrix /// A 2 x 2, column major matrix
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(Copy, Clone, PartialEq)] #[derive(Copy, Clone, PartialEq)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]
@ -47,8 +47,8 @@ pub struct Matrix2<S> {
/// A 3 x 3, column major matrix /// A 3 x 3, column major matrix
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(Copy, Clone, PartialEq)] #[derive(Copy, Clone, PartialEq)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]
@ -63,8 +63,8 @@ pub struct Matrix3<S> {
/// A 4 x 4, column major matrix /// A 4 x 4, column major matrix
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(Copy, Clone, PartialEq)] #[derive(Copy, Clone, PartialEq)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]

12
src/point.rs
View file

@ -29,8 +29,8 @@ use vector::{Vector1, Vector2, Vector3, Vector4};
/// A point in 1-dimensional space. /// A point in 1-dimensional space.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(PartialEq, Eq, Copy, Clone, Hash)] #[derive(PartialEq, Eq, Copy, Clone, Hash)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]
@ -40,8 +40,8 @@ pub struct Point1<S> {
/// A point in 2-dimensional space. /// A point in 2-dimensional space.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(PartialEq, Eq, Copy, Clone, Hash)] #[derive(PartialEq, Eq, Copy, Clone, Hash)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]
@ -52,8 +52,8 @@ pub struct Point2<S> {
/// A point in 3-dimensional space. /// A point in 3-dimensional space.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(PartialEq, Eq, Copy, Clone, Hash)] #[derive(PartialEq, Eq, Copy, Clone, Hash)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]

4
src/quaternion.rs
View file

@ -34,8 +34,8 @@ use vector::Vector3;
/// A [quaternion](https://en.wikipedia.org/wiki/Quaternion) in scalar/vector /// A [quaternion](https://en.wikipedia.org/wiki/Quaternion) in scalar/vector
/// form. /// form.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(Copy, Clone, Debug, PartialEq)] #[derive(Copy, Clone, Debug, PartialEq)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]

16
src/vector.rs
View file

@ -27,8 +27,8 @@ use num::{BaseNum, BaseFloat, PartialOrd};
/// A 1-dimensional vector. /// A 1-dimensional vector.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(PartialEq, Eq, Copy, Clone, Hash)] #[derive(PartialEq, Eq, Copy, Clone, Hash)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]
@ -39,8 +39,8 @@ pub struct Vector1<S> {
/// A 2-dimensional vector. /// A 2-dimensional vector.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(PartialEq, Eq, Copy, Clone, Hash)] #[derive(PartialEq, Eq, Copy, Clone, Hash)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]
@ -53,8 +53,8 @@ pub struct Vector2<S> {
/// A 3-dimensional vector. /// A 3-dimensional vector.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(PartialEq, Eq, Copy, Clone, Hash)] #[derive(PartialEq, Eq, Copy, Clone, Hash)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]
@ -69,8 +69,8 @@ pub struct Vector3<S> {
/// A 4-dimensional vector. /// A 4-dimensional vector.
/// ///
/// This type is marked as `#[repr(C, packed)]`. /// This type is marked as `#[repr(C)]`.
#[repr(C, packed)] #[repr(C)]
#[derive(PartialEq, Eq, Copy, Clone, Hash)] #[derive(PartialEq, Eq, Copy, Clone, Hash)]
#[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))] #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
#[cfg_attr(feature = "eders", derive(Serialize, Deserialize))] #[cfg_attr(feature = "eders", derive(Serialize, Deserialize))]