Update Rust crate hostname to 0.4.0

ecs/src/resources.rs

@@ -6,11 +6,9 @@ use std::{
 
 use utilities::prelude::{remove_life_time, remove_life_time_mut};
 
-type Untyped = dyn Any + Send + Sync;
-
 #[derive(Default)]
 pub struct Resources {
-    map: HashMap<TypeId, Box<Untyped>>,
+    map: HashMap<TypeId, Box<dyn Any + Send + Sync>>,
 }
 
 impl Resources {
@@ -36,23 +34,13 @@ impl Resources {
         self.get_opt::<T>().unwrap()
     }
 
-    pub fn get_by_type_id<T: Any + Send + Sync>(&self, type_id: TypeId) -> &T {
-        self.get_opt_by_type_id(type_id).unwrap()
-    }
-
     pub fn get_unchecked<'a, T: Any + Send + Sync>(&self) -> &'a T {
         unsafe { remove_life_time(self.get::<T>()) }
     }
 
     pub fn get_opt<T: Any + Send + Sync>(&self) -> Option<&T> {
-        self.get_opt_by_type_id(TypeId::of::<T>())
-    }
-
-    pub fn get_opt_by_type_id<T: Any + Send + Sync>(&self, type_id: TypeId) -> Option<&T> {
-        debug_assert_eq!(type_id, TypeId::of::<T>());
-
         self.map
-            .get(&type_id)
+            .get(&TypeId::of::<T>())
             .map(|any| Self::downcast_ref_unchecked(any))
     }
 
@@ -60,37 +48,16 @@ impl Resources {
         self.get_mut_opt::<T>().unwrap()
     }
 
-    pub fn get_mut_by_type_id<T: Any + Send + Sync>(&mut self, type_id: TypeId) -> &mut T {
-        self.get_mut_opt_by_type_id(type_id).unwrap()
-    }
-
-    pub fn get_mut_by_type_id_untyped(&mut self, type_id: TypeId) -> &mut Untyped {
-        self.get_mut_opt_by_type_id_untyped(type_id).unwrap()
-    }
-
     pub fn get_mut_unchecked<'a, T: Any + Send + Sync>(&mut self) -> &'a mut T {
         unsafe { remove_life_time_mut(self.get_mut::<T>()) }
     }
 
     pub fn get_mut_opt<T: Any + Send + Sync>(&mut self) -> Option<&mut T> {
-        self.get_mut_opt_by_type_id(TypeId::of::<T>())
-    }
-
-    pub fn get_mut_opt_by_type_id<T: Any + Send + Sync>(
-        &mut self,
-        type_id: TypeId,
-    ) -> Option<&mut T> {
-        debug_assert_eq!(type_id, TypeId::of::<T>());
-
         self.map
-            .get_mut(&type_id)
+            .get_mut(&TypeId::of::<T>())
             .map(|any| Self::downcast_mut_unchecked(any))
     }
 
-    pub fn get_mut_opt_by_type_id_untyped(&mut self, type_id: TypeId) -> Option<&mut Untyped> {
-        self.map.get_mut(&type_id).map(|any| any.as_mut())
-    }
-
     pub fn multi_mut(&mut self) -> ResourceMultiMut<'_> {
         ResourceMultiMut::new(&mut self.map)
     }
@@ -102,11 +69,11 @@ impl Resources {
 
 // helper
 impl Resources {
-    fn downcast_unchecked<T: Any + Send + Sync>(boxed: Box<Untyped>) -> Box<T> {
+    fn downcast_unchecked<T: Any + Send + Sync>(boxed: Box<dyn Any + Send + Sync>) -> Box<T> {
         unsafe { Box::from_raw(Box::into_raw(boxed) as *mut T) }
     }
 
-    fn downcast_ref_unchecked<T: Any + Send + Sync>(boxed_ref: &Box<Untyped>) -> &T {
+    fn downcast_ref_unchecked<T: Any + Send + Sync>(boxed_ref: &Box<dyn Any + Send + Sync>) -> &T {
         unsafe {
             let ptr_to_ptr: *const *const T =
                 transmute(destructure_traitobject::data(boxed_ref as *const _));
@@ -115,7 +82,9 @@ impl Resources {
         }
     }
 
-    fn downcast_mut_unchecked<T: Any + Send + Sync>(boxed_ref: &mut Box<Untyped>) -> &mut T {
+    fn downcast_mut_unchecked<T: Any + Send + Sync>(
+        boxed_ref: &mut Box<dyn Any + Send + Sync>,
+    ) -> &mut T {
         unsafe {
             let ptr_to_ptr: *mut *mut T =
                 transmute(destructure_traitobject::data(boxed_ref as *mut _));

presentation/Cargo.toml

@@ -9,7 +9,6 @@ vulkan-rs = { workspace = true }
 ui = { workspace = true }
 sdl2 = { workspace = true }
 anyhow = { workspace = true }
-destructure_traitobject = { workspace = true }
 
 openxr = { workspace = true, optional = true }
 openvr = { workspace = true, optional = true }

presentation/src/renderbackend.rs

@@ -6,7 +6,7 @@ use ecs::World;
 use ui::prelude::*;
 use vulkan_rs::prelude::*;
 
-use std::any::TypeId;
+use std::marker::PhantomData;
 use std::ops::Deref;
 use std::sync::{
     Arc, Mutex, RwLock,
@@ -49,7 +49,7 @@ impl Default for VRTransformations {
     }
 }
 
-pub struct RenderBackend {
+pub struct RenderBackend<S: TScene + 'static> {
     device: Arc<Device>,
     queue: Arc<Mutex<Queue>>,
 
@@ -61,10 +61,12 @@ pub struct RenderBackend {
 
     command_buffer: Arc<CommandBuffer>,
 
-    render_routines: Vec<(u32, TypeId)>,
+    post_processes: Mutex<Vec<Arc<dyn PostProcess>>>,
+
+    s: PhantomData<S>,
 }
 
-impl RenderBackend {
+impl<S: TScene + 'static> RenderBackend<S> {
     pub fn new(
         device: &Arc<Device>,
         queue: &Arc<Mutex<Queue>>,
@@ -92,7 +94,9 @@ impl RenderBackend {
 
             command_buffer,
 
-            render_routines: Vec::new(),
+            post_processes: Mutex::new(Vec::new()),
+
+            s: PhantomData,
         })
     }
 
@@ -101,7 +105,7 @@ impl RenderBackend {
     }
 }
 
-impl RenderBackend {
+impl<S: TScene + 'static> RenderBackend<S> {
     pub fn device(&self) -> &Arc<Device> {
         &self.device
     }
@@ -166,23 +170,18 @@ impl RenderBackend {
             }
         }
 
-        // make a call to the connected scenes
+        // make a call to the connected scene
-        self.render_routines
+        world.resources.get_mut_unchecked::<S>().process(
-            .iter_mut()
-            .try_for_each(|(_, type_id)| {
-                let scene: &mut dyn TScene = unsafe {
-                    std::mem::transmute(destructure_traitobject::data_mut(
-                        world.resources.get_mut_by_type_id_untyped(*type_id),
-                    ))
-                };
-
-                scene.process(
             &mut buffer_recorder,
             &*self.swapchain_images.lock().unwrap(),
             &image_indices,
             world,
         )?;
-            })?;
+
+        // post processing
+        for post_process in self.post_processes.lock().unwrap().iter() {
+            post_process.process(&mut buffer_recorder, &image_indices)?;
+        }
 
         Ok(&self.command_buffer)
     }
@@ -205,37 +204,49 @@ impl RenderBackend {
             SeqCst,
         );
 
-        self.render_routines
+        world
-            .iter_mut()
+            .resources
-            .try_for_each(|(_, type_id)| {
+            .get_mut::<S>()
-                let scene: &mut dyn TScene = unsafe {
+            .resize(width as f32, height as f32, &images)?;
-                    std::mem::transmute(destructure_traitobject::data_mut(
+        *self.swapchain_images.lock().unwrap() = images;
-                        world.resources.get_mut_by_type_id_untyped(*type_id),
-                    ))
-                };
 
-                scene.resize(width, height, &images)
+        for post_process in self.post_processes.lock().unwrap().iter() {
-            })?;
+            post_process.resize(width, height, &*self.swapchain_images.lock().unwrap())?;
+        }
 
         Ok(())
     }
 
-    /// lower priority means it is more important
+    pub fn add_post_processing_routine(&self, post_process: Arc<dyn PostProcess>) {
-    pub fn add_render_routine<T: TScene>(&mut self, priority: u32) {
+        let mut post_processes = self.post_processes.lock().unwrap();
-        self.render_routines.push((priority, TypeId::of::<T>()));
+
-        self.render_routines.sort_by_key(|(p, _)| *p);
+        // only add if it isn't present already
+        if post_processes
+            .iter()
+            .find(|p| Arc::ptr_eq(p, &post_process))
+            .is_none()
+        {
+            post_processes.push(post_process);
+
+            post_processes.sort_by(|lhs, rhs| lhs.priority().cmp(&rhs.priority()));
+        }
     }
 
-    pub fn remove_render_routine<T: TScene>(&mut self) {
+    pub fn remove_post_processing_routine(&self, post_process: Arc<dyn PostProcess>) {
-        if let Some(index) = self
+        let mut post_processes = self.post_processes.lock().unwrap();
-            .render_routines
+
+        if let Some(index) = post_processes
             .iter()
-            .find(|(_, type_id)| *type_id == TypeId::of::<T>())
+            .position(|p| Arc::ptr_eq(p, &post_process))
         {
-            self.render_routines.remove(index)
+            post_processes.remove(index);
         }
     }
 
+    pub fn clear_post_processing_routines(&self) {
+        self.post_processes.lock().unwrap().clear();
+    }
+
     // getter
     pub fn image_count(&self) -> usize {
         self.image_count.load(SeqCst)
@@ -246,7 +257,7 @@ impl RenderBackend {
     }
 }
 
-impl RenderBackend {
+impl<S: TScene + 'static> RenderBackend<S> {
     #[inline]
     fn clear_image(
         buffer_recorder: &mut CommandBufferRecorder<'_>,

presentation/src/traits.rs

@@ -8,7 +8,7 @@ use std::sync::Arc;
 
 use crate::prelude::*;
 
-pub trait TScene: Send + Sync + 'static {
+pub trait TScene: Send + Sync {
     fn process(
         &mut self,
         buffer_recorder: &mut CommandBufferRecorder<'_>,
@@ -25,6 +25,18 @@ pub trait TScene: Send + Sync + 'static {
     ) -> Result<()>;
 }
 
+pub trait PostProcess: Send + Sync {
+    /// higher priority means, it is executed earlier
+    fn priority(&self) -> u32;
+
+    fn process(
+        &self,
+        buffer_recorder: &mut CommandBufferRecorder<'_>,
+        indices: &TargetMode<usize>,
+    ) -> Result<()>;
+    fn resize(&self, width: u32, height: u32, images: &TargetMode<Vec<Arc<Image>>>) -> Result<()>;
+}
+
 pub trait RenderCore: std::fmt::Debug + Send + Sync {
     fn next_frame(&mut self, world: &mut World) -> Result<bool>;
 
@@ -35,12 +47,13 @@ pub trait RenderCore: std::fmt::Debug + Send + Sync {
         VK_IMAGE_LAYOUT_PRESENT_SRC_KHR
     }
 
-    // render routines
-    fn add_render_routine<T: TScene>(&mut self, priority: u32);
-    fn remove_render_routine<T: TScene>(&mut self);
-
     fn set_clear_color(&self, color: [f32; 4]);
 
+    // post process handling
+    fn add_post_processing_routine(&self, post_process: Arc<dyn PostProcess>);
+    fn remove_post_processing_routine(&self, post_process: Arc<dyn PostProcess>);
+    fn clear_post_processing_routines(&self);
+
     // getter
     fn image_count(&self) -> usize;
     fn images(&self) -> TargetMode<Vec<Arc<Image>>>;

presentation/src/vri/mod.rs

@@ -92,12 +92,16 @@ pub mod openvrrendercore {
         }
 
         // post process handling
-        fn add_render_routine<T: TScene>(&mut self, priority: u32) {
+        fn add_post_processing_routine(&self, _post_process: Arc<dyn PostProcess>) {
-            todo!()
+            unimplemented!()
         }
 
-        fn remove_render_routine<T: TScene>(&mut self) {
+        fn remove_post_processing_routine(&self, _post_process: Arc<dyn PostProcess>) {
-            todo!()
+            unimplemented!()
+        }
+
+        fn clear_post_processing_routines(&self) {
+            unimplemented!()
         }
 
         // getter